Skip to content

ensure that react useLiveQuery returns a stable ref when there are no changes #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

ensure that react useLiveQuery returns a stable ref when there are no changes #388

merged 4 commits into from
Aug 19, 2025

Conversation

samwillis
Copy link
Collaborator

@samwillis samwillis commented Aug 9, 2025 •
edited
Loading

incorporates the test from #349 and fixes the issue.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2025

🦋 Changeset detected

Latest commit: 38a224c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/react-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 9, 2025

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@388

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@388

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@388

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@388

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@388

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@388

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@388

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@388

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@388

commit: 38a224c

@samwillis samwillis mentioned this pull request Aug 9, 2025
Closed
@samwillis samwillis requested a review from kevin-dp August 9, 2025 10:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Size Change: 0 B

Total Size: 58.5 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 9.85 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 2.98 kB
./packages/db/dist/esm/index.js 1.51 kB
./packages/db/dist/esm/indexes/auto-index.js 689 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.47 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 4.19 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.79 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.03 kB
./packages/db/dist/esm/query/compiler/index.js 1.74 kB
./packages/db/dist/esm/query/compiler/joins.js 1.56 kB
./packages/db/dist/esm/query/compiler/order-by.js 677 B
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 318 B
./packages/db/dist/esm/query/live-query-collection.js 2.45 kB
./packages/db/dist/esm/query/optimizer.js 2.44 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 419 B
./packages/db/dist/esm/utils/btree.js 5.93 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Size Change: 0 B

Total Size: 1.05 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 902 B

compressed-size-action::react-db-package-size

This was referenced Aug 10, 2025
Open
Closed
@samwillis samwillis merged commit 7b36a3f into main Aug 19, 2025
6 checks passed
@samwillis samwillis deleted the stable-ref branch August 19, 2025 13:54
@github-actions github-actions bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-dp kevin-dp kevin-dp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samwillis @kevin-dp @mharris717